Skip to content

deprecate insights module#270

Merged
rootflo-hardik merged 3 commits intodevelopfrom
CU-86d2hrmgw-deprecate-insights-module
Apr 8, 2026
Merged

deprecate insights module#270
rootflo-hardik merged 3 commits intodevelopfrom
CU-86d2hrmgw-deprecate-insights-module

Conversation

@rootflo-hardik
Copy link
Copy Markdown
Contributor

@rootflo-hardik rootflo-hardik commented Apr 4, 2026

Summary by CodeRabbit

  • Removed Features
    • Insights module removed: dynamic query APIs, parsed-data-object endpoints, alerting/insights generation, and cloud-backed PVO services.
    • BigQuery/Redshift connectors and related usage-metrics functionality removed.
  • Tests
    • Insight module test suite and fixtures removed.
  • Chores
    • Packaging/config and Docker build no longer include the insights module; dependency list updated.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e05fcf5-942b-497b-9026-ff3522e67c52

📥 Commits

Reviewing files that changed from the base of the PR and between addb00a and efed2f3.

⛔ Files ignored due to path filters (1)
  • wavefront/server/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • wavefront/server/apps/floware/pyproject.toml
✅ Files skipped from review due to trivial changes (1)
  • wavefront/server/apps/floware/pyproject.toml

📝 Walkthrough

Walkthrough

This PR removes the insights module from the floware application: dependency-injection declarations and container wiring, all insights module code (controllers, services, repositories, DB connectors, models, utilities), tests, and associated packaging/Docker integration entries.

Changes

Cohort / File(s) Summary
App DI & Server
wavefront/server/apps/floware/floware/di/application_container.py, wavefront/server/apps/floware/floware/server.py
Removed insights_service / pvo_repository DI declarations and eliminated InsightsContainer/insights router wiring from server init.
Module DI Container
wavefront/server/modules/insights_module/insights_module/insights_container.py
Deleted the entire InsightsContainer and its cloud provider / connector selection and service registrations.
API Controllers & Router
wavefront/server/modules/insights_module/insights_module/controllers/...
wavefront/server/modules/insights_module/insights_module/controllers/router.py
Deleted controllers and composite router that provided /v1/insights endpoints (dynamic queries, pdo endpoints, audio/transcript).
Services
wavefront/server/modules/insights_module/insights_module/service/...
Removed service modules: dynamic query execution, insights extraction, PDO/cloud service interfaces (AWS/GCP implementations), and usage metric service.
Repository / Data Access
wavefront/server/modules/insights_module/insights_module/repository/pvo_repository.py
Deleted PVO repository and all SQL/YAML loading, query execution, and data transformation logic.
Database Connectors
wavefront/server/modules/insights_module/insights_module/db/redshift_connector.py, .../bigquery_connector.py
Removed Redshift and BigQuery connector implementations and related config dataclasses and helpers.
Models & Parsers
wavefront/server/modules/insights_module/insights_module/models/...
Deleted model/dataclass definitions and YAML/dict parsing utilities for dynamic queries, signals, lead queries, and aggregates.
Utilities
wavefront/server/modules/insights_module/insights_module/utils/helper.py
Removed helper for building OData-style data filters.
Tests & Test Fixtures
wavefront/server/modules/insights_module/tests/conftest.py, .../test_pvo_controller.py
Deleted insights-module test fixtures and all controller integration tests.
Packaging & Docker
wavefront/server/modules/insights_module/pyproject.toml, wavefront/server/apps/floware/pyproject.toml, wavefront/server/docker/floware.Dockerfile
Removed the insights-module pyproject, removed insights-module from floware dependencies and workspace sources, and stopped copying insights_module into the Docker image; added psycopg2-binary to floware deps.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~65 minutes

Possibly related PRs

Suggested reviewers

  • vizsatiz

Poem

🐰 I hopped through code where insights used to play,

Queries, signals, models — all packed away.
The routers and DBs now quiet and still,
I twitched my nose, and cleared out that hill.
A lighter repo hops off into day ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'deprecate insights module' directly and clearly describes the main change: the insights module is being removed/deprecated throughout the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch CU-86d2hrmgw-deprecate-insights-module

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

vishnurk6247
vishnurk6247 previously approved these changes Apr 4, 2026
# Conflicts:
#	wavefront/server/modules/insights_module/pyproject.toml
#	wavefront/server/uv.lock
@rootflo-hardik rootflo-hardik merged commit a3a7752 into develop Apr 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants