Conversation
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
Let us discuss the FTS example.
Otherwise I like it.
| <param name="lower_limits">-100</param> | ||
| <param name="upper_limits">100</param> | ||
| </state_interface> | ||
| <state_interface name="fx"/> |
There was a problem hiding this comment.
I would like to have limits here... Especially with FTS is that important since one can easily get measurements outside calibrated range.
There was a problem hiding this comment.
This is often defined per-axis. see: https://www.ati-ia.com/products/ft/ft_models.aspx?id=Mini45
There was a problem hiding this comment.
Let's discuss that on the roadmap repo if you don't mind. This PR simply brings the examples we have up to date.
| <state_interface name="tx"/> | ||
| <state_interface name="ty"/> | ||
| <state_interface name="tz"/> | ||
| <param name="frame_id">kuka_tcp</param> |
There was a problem hiding this comment.
| <param name="frame_id">kuka_tcp</param> | |
| <param name="frame_id">rrbot_tcp</param> |
There was a problem hiding this comment.
This is directly from the roadmap repo.
There was a problem hiding this comment.
Let's also change there. It doesn't make sense to call this kuka_tcp
There was a problem hiding this comment.
you can change it here or not, as you wish.
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
I approved and we can add changes from ros-controls/roadmap#32 in the next PR. As you prefer.
* docs: 📝 Port over ros2_control GitHub templates * This first commit is an exact copy. Next commit will be any changes to adapt to ros2_controllers * docs: 📝 Convert ros2_control references to ros2_controller
2 participants
No description provided.