Add 6D robot description to ros2_control_test_assets#3032
Add 6D robot description to ros2_control_test_assets#3032christophfroehlich merged 5 commits intoros-controls:masterfrom
Conversation
Signed-off-by: Naitik Pahwa <naitikpahwa18@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new reusable test asset header to ros2_control_test_assets that provides a 6-DOF robot URDF and matching SRDF as embedded string constants, intended for reuse across multiple controller test suites.
Changes:
- Added
test_asset_6d_robot_description.hppcontainingvalid_6d_robot_urdfandvalid_6d_robot_srdfstring assets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…_asset_6d_robot_description.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Naitik Pahwa <naitikpahwa18@users.noreply.github.com>
destogl
left a comment
There was a problem hiding this comment.
I think we should switch to another robot description that we are using in the ros2_control_demos. Here it is: https://github.com/ros-controls/ros2_control_demos/tree/master/ros2_control_demo_description/r6bot
@christophfroehlich, @bmagyar and @saikishor should we copy this description or move it here and then reference it always from test assets? Or is maintaining two copies OK in this case?
Co-authored-by: Dr. Denis <denis.stogl@b-robotized.com>
christophfroehlich
left a comment
There was a problem hiding this comment.
@destogl I don't think it is a good idea to use the r6bot from the demos here unless we copy it. Moving the full description package incl. meshes will bloat this repo, and we can't make the demos a dependency of the test assets package. We can merge this as it is, because the kuka description was already in admittance_controller. If we need to, we can always copy the r6bot here and replace it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3032 +/- ##
=======================================
Coverage 89.08% 89.09%
=======================================
Files 160 160
Lines 19751 19750 -1
Branches 1597 1597
=======================================
Hits 17596 17596
- Misses 1488 1490 +2
+ Partials 667 664 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
0870f0e
into
ros-controls:master
(cherry picked from commit 0870f0e)
(cherry picked from commit 0870f0e)
Description
Adds
test_asset_6d_robot_description.hpptoros2_control_test_assetspackage to make it reusable across multiple controllers.Related Issues
Part of fix for ros-controls/ros2_controllers#450
Additional context
This PR should be merged in coordination with the ros-controls/ros2_controllers#2173