GPL custom validator: Use tl_expected from libexpected-dev instead#2212
Merged
christophfroehlich merged 6 commits intomasterfrom Mar 25, 2026
Merged
GPL custom validator: Use tl_expected from libexpected-dev instead#2212christophfroehlich merged 6 commits intomasterfrom
christophfroehlich merged 6 commits intomasterfrom
Conversation
github-actions
bot
requested review from
aprotyas,
bmagyar,
homalozoa,
moriarty and
saikishor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2212 +/- ##
==========================================
- Coverage 84.80% 84.78% -0.02%
==========================================
Files 153 153
Lines 15244 15234 -10
Branches 1321 1321
==========================================
- Hits 12927 12916 -11
- Misses 1835 1836 +1
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
previously approved these changes
Mar 23, 2026
christophfroehlich
added
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
(cherry picked from commit 813ed25) # Conflicts: # joint_trajectory_controller/CMakeLists.txt # joint_trajectory_controller/include/joint_trajectory_controller/validate_jtc_parameters.hpp
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
(cherry picked from commit 813ed25)
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
(cherry picked from commit 813ed25)
christophfroehlich
pushed a commit
that referenced
this pull request
Mar 26, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
Mar 26, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs PickNikRobotics/generate_parameter_library#322
and reverts #2127