[JSB] Fix joint_state message corruption issue (backport #2217)#2218
Open
mergify[bot] wants to merge 2 commits intojazzyfrom
Open
[JSB] Fix joint_state message corruption issue (backport #2217)#2218mergify[bot] wants to merge 2 commits intojazzyfrom
mergify[bot] wants to merge 2 commits intojazzyfrom
Conversation
(cherry picked from commit 2942d73)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jazzy #2218 +/- ##
==========================================
+ Coverage 84.38% 84.41% +0.03%
==========================================
Files 153 153
Lines 15116 15145 +29
Branches 1338 1340 +2
==========================================
+ Hits 12755 12785 +30
Misses 1873 1873
+ Partials 488 487 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
Is this related?
[ RUN ] JointStateBroadcasterTest.CorrectMappingWhenInterfaceReadFailsTest
[INFO] [1773784257.686159051] [joint_state_broadcaster]: Publishing state interfaces defined in 'joints' and 'interfaces' parameters.
[WARN] [1773784257.686193436] [joint_state_broadcaster]: Mapping from 'position' to interface 'position' will not be done, because 'position' is defined in 'interface' parameter.
Error: ROR] [1773784257.686952976] [joint_state_broadcaster]: Failed to parse robot description. Will publish all the interfaces with 'position', 'velocity' and 'effort'
terminate called after throwing an instance of 'std::length_error'
what(): basic_string::_M_create
Stack trace (most recent call last):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported by @christophfroehlich that sometimes the joint state message is corrupted with incorrect data.
This is an automatic backport of pull request #2217 done by [Mergify](https://mergify.com).