fix(joint_state_broadcaster): suppress confusing warning for standard interfaces#2276
Open
greencookie-afk wants to merge 1 commit intoros-controls:masterfrom
Conversation
… interfaces When using standard interfaces like 'velocity' with the default mapping, the warning 'Mapping from velocity to interface velocity will not be done' is confusing because no mapping is actually needed. This change only shows the warning when there's a custom mapping being ignored (i.e., when interface name differs from the JointState field name). Fixes ros-controls#2261
Author
|
@christophfroehlich, I opened a PR for this issue. Would you be able to review when you have a chance? I am a beginner so any feedback will be appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the confusing warning message from
JointStateBroadcasterwhen using standard interfaces likevelocitywith the default mapping.Problem
When configuring the broadcaster with standard interfaces:
The following confusing warning was displayed:
This warning is confusing because:
velocityfieldSolution
The warning is now only displayed when there's an actual custom mapping being ignored (i.e., when the interface name differs from the JointState field name).
For example, if someone had:
Then the warning would still be shown because the custom mapping
custom_velocity_interface->velocitywould be ignored.But for the standard case where
interfaces: [velocity]and the default mappingvelocity->velocity, no warning is shown because no mapping is needed.Changes
joint_state_broadcaster.cppto only print the warning wheninterface != interface_to_mapRelated Issue
Fixes #2261