Conversation
Contributor
|
Hi @k-okada, Nice the contribution guideline addition, including the tutorial! One thing that I think it is not clear is if this package only contains the c++ samples(as it is - just a porting) from opencv or if we can add features on this samples(i.e. on the example that you used here, can I add the CLAHE to the histogramEqualization). Also, can I use samples from another place that besides here(like here)? Thanks |
Contributor
Author
|
Hi
You can use samples from other places.
I just afraid people put their code randomly and make repository messy. So
I want to put some guidelines to show the set of codes to be put in this
package.
So adding
https://github.com/opencv/opencv/tree/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/samples/tapi
would be good idea and add list of code as
https://github.com/opencv/opencv/tree/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/samples/tapi,
so that other pople can understand our next scope to which function to be
added.
Based on same idea, I also require msg/ directory should have corresponding
OpenCV data class. Of course there would be much better design of output
messages, but, for example, re-use existing visualization node, we do not
want to accept arbitrary message type.
…--
◉ Kei Okada
2020年10月9日(金) 21:29 Ivan Oliveira Tarifa <notifications@github.com>:
Hi @k-okada <https://github.com/k-okada>,
Nice the contribution guideline addition, including the tutorial! One
thing that I think it is not clear is if this package only contains the c++
samples(as it is - just a porting) from opencv or if we can add features on
this samples(i.e. on the example that you used here, can I add the CLAHE to
the histogramEqualization). Also, can I use samples from another place that
besides here
<https://github.com/opencv/opencv/tree/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/samples/cpp>(like
here
<https://github.com/opencv/opencv/tree/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/samples/tapi>
)?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYNXF55C3QBEUJK4WA6ADSJ36YZANCNFSM4SJS76AQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.