[ROS-O] Fix build error with Boost 1.83#146
Closed
furushchev wants to merge 2 commits intoros-perception:indigofrom
Closed
[ROS-O] Fix build error with Boost 1.83#146furushchev wants to merge 2 commits intoros-perception:indigofrom
furushchev wants to merge 2 commits intoros-perception:indigofrom
Conversation
Contributor
Author
|
I successfully built the package on Ubuntu 20.04 / Noetic and Ubuntu 24.04 / One while the CI failed... |
Contributor
Author
|
@k-okada Hello! I'm wondering what is the current situation of the maintenance in this repository. |
k-okada
added a commit
to k-okada/opencv_apps
that referenced
this pull request
Feb 15, 2025
Merged
Contributor
Author
|
@k-okada Thank you for your quick merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
boost::filesystem::path::appendfunction defined in thesrc/nodelet/face_recognition_nodelet.cpphave conflict with the boost function.In this PR, I removed the function and expanded the content to the only called place (in the
user_expanded_pathfunction).In addition to that, I fixed the cmake warning: