Skip to content

Add adding_image#29

Merged
k-okada merged 4 commits intoros-perception:indigofrom
iory:add-image
Sep 1, 2016
Merged

Add adding_image#29
k-okada merged 4 commits intoros-perception:indigofrom
iory:add-image

Conversation

@iory
Copy link
Copy Markdown
Contributor

@iory iory commented Aug 30, 2016

based on opencv's tutorial code.

adding_image

k-okada
k-okada reviewed Aug 30, 2016
View reviewed changes
nodelet_plugins.xml Outdated
@@ -1,5 +1,9 @@
<library path="lib/libopencv_apps">

<class name="opencv_apps/adding_image" type="adding_image::AddingImageNodelet" base_class_type="nodelet::Nodelet">
Copy link
Copy Markdown
Contributor

@k-okada k-okada Aug 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow old classname convention, this should be "adding_image/adding_image" until #21

Copy link
Copy Markdown
Contributor Author

@iory iory Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@iory iory force-pushed the add-image branch 5 times, most recently from f202324 to a63d15a Compare September 1, 2016 02:07
@k-okada
Copy link
Copy Markdown
Contributor

k-okada commented Sep 1, 2016

thank you , the test seems unstable,
could you try to use use_sim_time and publish /clock, when you have time?
https://github.com/ros-perception/opencv_apps/blob/7face07ee414a6b6fcb3b59626f399da703b1b81/test/test-simple_compressed_example.test

@iory iory force-pushed the add-image branch 2 times, most recently from e81b9d1 to a1dec87 Compare September 1, 2016 08:51
@iory
Copy link
Copy Markdown
Contributor Author

iory commented Sep 1, 2016

I fixed it.
82ff0e2#diff-a850b0f48050090ab9fb160aeb18adbfR3

@k-okada k-okada merged commit e6eb493 into ros-perception:indigo Sep 1, 2016
@k-okada
Copy link
Copy Markdown
Contributor

k-okada commented Sep 1, 2016

thx

@k-okada
Copy link
Copy Markdown
Contributor

k-okada commented Sep 1, 2016

please update http://wiki.ros.org/opencv_apps, you may need to take another image, the quality of https://cloud.githubusercontent.com/assets/4690682/18102788/cfebb5a4-6f2e-11e6-844a-49bd5165b8dc.png is not used in the wikipage, the window is overlapped, background is shown, .... , I used output image of the test code for wiki pages)

@k-okada
Copy link
Copy Markdown
Contributor

k-okada commented Sep 21, 2016

please paste output images here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iory @k-okada