Fix user data unpacking in noetic#57
Draft
corot wants to merge 1 commit intoros-visualization:melodic-develfrom
Draft
Fix user data unpacking in noetic#57corot wants to merge 1 commit intoros-visualization:melodic-develfrom
corot wants to merge 1 commit intoros-visualization:melodic-develfrom
Conversation
Contributor
|
@corot can you provide example code to reproduce this problem? |
Author
To my understanding, this is a general problem in noetic. i.e. decoding any msg fails. Which makes sense because we encode using base64. Can you visualize userdata on noetic w/o this fix? |
Contributor
Yes, but at this time it seems that this PR has not fixed the visualization failure yet. I got the following error with #54 code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: create noetic-devel branch and change the target for this PR
I will keep as draft meanwhile
Without this PR, on noetic, unpacking any user data fails with