Open
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Darwin call conventions fixes. Unnecessary X bit on page creation since changed afterwards (otherwise crash on Darwin/ARM).
The variable `name` contains everything after the `@`, which includes the `file:` prefix. The variable `val` should contain everything after the `file:` prefix, which should be appropriate for comparison with the library file name.
mprotect symbol is needed too. also __clear_cache seems buggy on ARM64 thus calling directly related MacOS feature.
This fixes the 32-bit travis tests - the code doesn't deal with the addend anyway.
Use gnu_hash in preference to the standard hash table, as it's more efficient, and fall back to the tranditional table if we can't find it. This should fix problems on systems that do not provide the traditional ELF hash table for symbols.
…to check jmp/call supported by clang and gcc.
Forcing users to build with -Werror only punishes those building with newer compilers or toolchains than those in the repository CI. While maintaining a warning-free build is a noble cause, the repository CI can be adjusted so that it is enforced only for the platforms you're testing and not every single user.
The build was failing due to references to non-existent types `ElfAddr` and `ElfOff`. These should be replaced with the correct portable type macros `ElfW(Addr)` and `ElfW(Off)` respectively.
…m_upstream Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Member
Author
|
CI here: ros2/mimick_vendor#42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.