Skip to content

Set noble as default ubuntu distribution.#760

Merged
clalancette merged 1 commit intomasterfrom
marcoag/noble_default_distro
Apr 16, 2024
Merged

Set noble as default ubuntu distribution.#760
clalancette merged 1 commit intomasterfrom
marcoag/noble_default_distro

Conversation

@marcoag
Copy link
Contributor

@marcoag marcoag commented Mar 22, 2024

Adding noble as default ubuntu distribution.

This shouldn't affect iron or humble as they seem to override this value:

ci/create_jenkins_job.py

Lines 462 to 463 in 272db18

'ros_distro': 'humble',
'ubuntu_distro': 'jammy',

ci/create_jenkins_job.py

Lines 476 to 477 in 272db18

'ros_distro': 'iron',
'ubuntu_distro': 'jammy',

@clalancette
Copy link
Contributor

As it stands, the one reason we can't do this is because python3-flake8 is still broken in Noble. @j-rivero is working on getting that solved in Noble proper, and @claraberendsen may be working on a workaround (by pulling the package from noble-proposed) for the short-term.

@claraberendsen
Copy link
Contributor

@clalancette @marcoag This is the branch to run ci with flake8 from noble-proposed instead of noble. However there seems to be a new error there related to python.

@marcoag marcoag marked this pull request as ready for review April 1, 2024 08:33
@clalancette
Copy link
Contributor

Before we can merge this one in, we need #766 and some of the fixes from #761 as well.

@wjwwood
Copy link
Member

wjwwood commented Apr 2, 2024

lgtm pending #761

@clalancette
Copy link
Contributor

clalancette commented Apr 8, 2024

All right, I believe that we have everything we need now. Here is CI on Noble with the current state of the repository:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Clang Build Status

@clalancette
Copy link
Contributor

Bah, we still need another PR. See #769

Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
@clalancette clalancette force-pushed the marcoag/noble_default_distro branch from 99e172a to b09c9c9 Compare April 16, 2024 18:00
@clalancette
Copy link
Contributor

All right, all CI for this was done in #769 . I'm going to approve, merge, and then deploy this change so we start using Noble as the default for CI.

@clalancette clalancette merged commit b6cd705 into master Apr 16, 2024
@delete-merged-branch delete-merged-branch bot deleted the marcoag/noble_default_distro branch April 16, 2024 18:05
@clalancette
Copy link
Contributor

And this has now been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants