Conversation
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
|
I must add that the tests seem a bit flaky locally; maybe waiting for a process start event or delay before loading the components could help. Another option is to migrate to |
fujitatomoya
left a comment
There was a problem hiding this comment.
@SuperJappie08 thanks for trying to fix this.
obviously this is missing as you pointed out.
i am not sure about this fix. instead API_COMPOSITION_EXECUTABLE should be added to CMakeLists.txt just like the others such as MANUAL_COMPOSITION_EXECUTABLE?
|
@fujitatomoya, I tried that, but it was unclear to me which executables those fields should be. (because of the reason given below and the I tried my current solution (using I could change it to be like that if that would be better. |
|
I've done some looking around, and the test was disabled in #319. The substitutions probably were used since it was a local compile target of this package. So I think the best way forward is most likely to use the |
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Description
Enables the API launch tests of the composition package (in some workable form)
Fixes #747
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
I do not use a generated substitution anymore, since it was unclear which binary path would have matched:
API_COMPOSITION_EXECUTABLEAPI_COMPOSITION_CLI_EXECUTABLE