Skip to content

Declare Boolean Launch Argument#944

Open
DLu wants to merge 2 commits intoros2:rollingfrom
DLu:declare_boolean_launch
Open

Declare Boolean Launch Argument#944
DLu wants to merge 2 commits intoros2:rollingfrom
DLu:declare_boolean_launch

Conversation

@DLu
Copy link
Contributor

@DLu DLu commented Feb 12, 2026

Description

Just a bit of syntactic sugar to make it easier to use boolean launch arguments. It tidies up launch files and avoids capitalization errors like

[ERROR] [launch.actions.declare_launch_argument]: Argument "use_rviz" provided value "True" is not valid. Valid options are: ['true', 'false']

Is this user-facing behavior change?

Yes, it adds a new shortcut.

Did you use Generative AI?

No.

@DLu
Declare Boolean Launch Argument
b1917ec 
Signed-off-by: David V. Lu <davidvlu@gmail.com>
@DLu DLu force-pushed the declare_boolean_launch branch from b9a74c2 to b1917ec Compare February 12, 2026 20:46
@DLu
Copy link
Contributor Author

DLu commented Feb 12, 2026

Current results for a preliminary GitHub search of potential usage: 1.2K

@asymingt asymingt self-assigned this Feb 19, 2026
@asymingt
Copy link
Member

asymingt commented Feb 19, 2026

Pulls: #944
Gist: https://gist.githubusercontent.com/asymingt/1ad45aa598b1abcaf6d5fd6e0acc139e/raw/352125750b108c7e198231b7eae4731a4b73304f/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_xml launch_yaml
TEST args: --packages-above launch launch_xml launch_yaml
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18262

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

asymingt
asymingt reviewed Feb 19, 2026
View reviewed changes
Copy link
Member

@asymingt asymingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good; just two small comments. Thanks for the contribution. I'm waiting on a green CI to make sure there are no hidden consequences.

@asymingt asymingt mentioned this pull request Feb 20, 2026
Open
1 task
@DLu
PR Feedback
59dea3b 
Signed-off-by: David V. Lu <davidvlu@gmail.com>
@asymingt
Copy link
Member

asymingt commented Feb 24, 2026 •
edited
Loading

Pulls: #944
Gist: https://gist.githubusercontent.com/asymingt/1ad45aa598b1abcaf6d5fd6e0acc139e/raw/352125750b108c7e198231b7eae4731a4b73304f/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_xml launch_yaml
TEST args: --packages-above launch launch_xml launch_yaml
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18309

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@DLu
Copy link
Contributor Author

DLu commented Feb 26, 2026

Any hints on what to do with the CI?

@asymingt
Copy link
Member

asymingt commented Feb 26, 2026

Any hints on what to do with the CI?

Might be an unrelated change. I'll take a look when I get back to my computer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asymingt asymingt asymingt approved these changes

Assignees

@asymingt asymingt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DLu @asymingt