honor cancel() issued before spin_until_future_complete().#3174
Open
fujitatomoya wants to merge 1 commit into
Open
honor cancel() issued before spin_until_future_complete().#3174fujitatomoya wants to merge 1 commit into
fujitatomoya wants to merge 1 commit into
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
jmachowinski
requested changes
Jun 12, 2026
jmachowinski
left a comment
jmachowinski
left a comment
Collaborator
There was a problem hiding this comment.
We should also change the while loops in the spins, to only react to the cancel_request
| // bail out early instead of re-arming spinning and blocking forever in | ||
| // wait_for_work(). | ||
| cancel_requested_.store(true); | ||
| spinning.store(false); |
Collaborator
There was a problem hiding this comment.
This is now wrong.
The cancel should not touch the spinning at all, it shall be only controlled by the spin functions.
This would also fix a bug, that is_spinning would return false, directly even after the cancel, even though the executor might still be doing stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3172
Is this user-facing behavior change?
Yes, but it only gets better.
Did you use Generative AI?
Yes, Claude Opus 4.7 partially, especially on test cases.
Additional Information