Retrieve HistoryQoS in discovery when available (backport #829)#830
Merged
Retrieve HistoryQoS in discovery when available (backport #829)#830
HistoryQoS in discovery when available (backport #829)#830Conversation
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e78f3f4)
Contributor
|
Pulls: #830, ros2/rcl#1247, ros2/ros2cli#1044
|
This was referenced Jun 4, 2025
ahcorde
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the HistoryQoS to the entities discovery callback when available.
Related tests PRs
HistoryQoSin test_info_by_topic rcl#1242HistoryQoSin test_ros2cli_daemon ros2cli#1040Fixes #684
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
Should be backported only to
KiltedThis is an automatic backport of pull request #829 done by Mergify.