Add thread-local TypeSupport cache to rmw_serialize/deserialize#866
Draft
mjcarroll wants to merge 3 commits intoros2:rollingfrom
Draft
Add thread-local TypeSupport cache to rmw_serialize/deserialize#866mjcarroll wants to merge 3 commits intoros2:rollingfrom
mjcarroll wants to merge 3 commits intoros2:rollingfrom
Conversation
added 3 commits
March 5, 2026 07:26
- Implemented thread_local MessageTypeSupport_cpp and TypeSupportCache - Eliminates per-call hash-map lookup and mutex overhead - Significantly improves performance for small and high-frequency messages
This reverts commit 7c2a0f6.
- Implemented thread_local MessageTypeSupport_cpp and TypeSupportCache - Eliminates per-call hash-map lookup and mutex overhead - Significantly improves performance for small and high-frequency messages
MiguelCompany
requested changes
Mar 5, 2026
Collaborator
MiguelCompany
left a comment
MiguelCompany
left a comment
There was a problem hiding this comment.
Very nice optimization!
Sadly, DCO needs to be fixed
fujitatomoya
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a thread_local MessageTypeSupport_cpp and TypeSupportCache to rmw_serialize and rmw_deserialize. It eliminates per-call hash-map lookup and mutex overhead, significantly improving performance for small and high-frequency messages.
Generated with the help of Claude Sonnet 4.6