Open
Conversation
Signed-off-by: Oren Bell <oren.bell@autonomous-teaming.ai>
nightduck
force-pushed
the
trace_rmw_take_loaned_message
branch
from
90280c4 to
0307582
Compare
fujitatomoya
approved these changes
Mar 18, 2026
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
MiguelCompany
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's difficult to fully trace a ROS2 system using zero-copy, because the message loaning functions don't invoke the rmw_take tracepoint, like the other rmw_take variants. This corrects for that.
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information