Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/Developer-Tools/Testing/Testing/Integration.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Background
----------

Where unit tests focus on validating a very specific piece of functionality, integration tests focus on validating the interaction between pieces of code.
In ROS 2 this is often accomplished by launching a system of one or several nodes, for example the `Gazebo simulator <https://gazebosim.org/home>`__ and the `Nav2 navigation <https://github.com/ros-planning/navigation2.git>`__ stack.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gazebosim.org/home is not broken link?

In ROS 2 this is often accomplished by launching a system of one or several nodes, for example the `Gazebo simulator <https://gazebosim.org>`__ and the `Nav2 navigation <https://github.com/ros-planning/navigation2.git>`__ stack.
As a result, these tests are more complex both to set up and to run.

A key aspect of ROS 2 integration testing is that nodes that are part of different tests shouldn't communicate with each other, even when run in parallel.
Expand Down
2 changes: 1 addition & 1 deletion source/Get-Started/About-ROS/About-ROS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ ROS works with other Open Robotics platforms to make development and deployment
* `Open-RMF`_ (Robotics Middleware Framework): Helps different robots work together and interact with building systems like lifts and doors.
* `ros-controls`_: Enables real-time control of robots using ROS.

.. _Gazebo: https://gazebosim.org/home
.. _Gazebo: https://gazebosim.org
.. _Open-RMF: https://www.open-rmf.org/
.. _ros-controls: https://control.ros.org/rolling/index.html

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ It also generates code for converting ROS message structures to and from DDS mes
This generator is also responsible for creating a shared library for the message package it is being used in, which is specific to the messages in the message package and to the DDS vendor being used.

As mentioned above, the ``rosidl_typesupport_introspection_<language>`` may be used instead of a vendor specific type support package if an RMW implementation supports runtime interpretation of messages.
This ability to programmatically send and receive types over topics without generating code beforehand is achieved by supporting the `DDS X-Types Dynamic Data standard <https://www.omg.org/spec/DDS-XTypes/>`_.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, https://www.omg.org/spec/DDS-XTypes/ is not a broken link?

This ability to programmatically send and receive types over topics without generating code beforehand is achieved by supporting the `DDS X-Types Dynamic Data standard <https://www.omg.org/spec/DDS-XTypes/About-DDS-XTypes/>`_.
As such, RMW implementations may provide support for the X-Types standard, and/or provide a package for type support generated at compile time specific to their DDS implementation.

For examples of example of DDS RMW implementation repositories,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ We will then simulate a lossy network connection between them and show how diffe
Prerequisites
-------------
This tutorial assumes you have a :doc:`working ROS 2 installation <../../../../Get-Started/Installation>` and OpenCV.
See the `OpenCV documentation <http://docs.opencv.org/doc/tutorials/introduction/table_of_content_introduction/table_of_content_introduction.html#table-of-content-introduction>`__ for its installation instructions.
See the `OpenCV documentation <https://docs.opencv.org/4.x/>`__ for its installation instructions.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need the ROS package ``image_tools``.

.. tabs::
Expand Down Expand Up @@ -157,7 +157,7 @@ Add network traffic

However, for macOS and Windows you can achieve a similar effect with the utilities "Network Link Conditioner" (part of the xcode tool suite) and `"Clumsy" <http://jagt.github.io/clumsy/index.html>`_, respectively, but they will not be covered in this tutorial.

We are going to use the Linux network traffic control utility, ``tc`` (`man page <http://linux.die.net/man/8/tc>`_) .

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not broke link.

We are going to use the Linux network traffic control utility, ``tc`` (`man page <https://man7.org/linux/man-pages/man8/tc.8.html>`_) .

.. code-block:: console

Expand Down
4 changes: 2 additions & 2 deletions source/The-ROS2-Project/Contributing/Developer-Guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ Change control process

* You can pass ``-s`` / ``--signoff`` to the ``git commit`` invocation or write the expected message manually (e.g. ``Signed-off-by: Your Name Developer <your.name@example.com>``).

* DCO is *not* required for pull requests that only address whitespace removal, typo correction, and other `trivial changes <http://cr.openjdk.java.net/~jrose/draft/trivial-fixes.html>`_.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here , this is not broken link.

* DCO is *not* required for pull requests that only address whitespace removal, typo correction, and other `trivial changes <https://openjdk.org/bylaws#trivial-change>`_.

* Always run CI jobs for all `tier 1 platforms <https://reps.openrobotics.org/rep-2000/#support-tiers>`_ for every pull request and include links to jobs in the pull request.
(If you don't have access to the Jenkins jobs someone will trigger the jobs for you.)
Expand Down Expand Up @@ -294,7 +294,7 @@ When filing an issue please make sure to:
Reasoning: This helps us narrow down the layer in the stack at which the issue might be.

- Include a list of steps to reproduce the issue.
- In case of a bug consider to provide a `short, self contained, correct (compilable), example <http://sscce.org/>`__.
- In case of a bug consider to provide a `short, self contained, correct (compilable), example <https://stackoverflow.com/help/minimal-reproducible-example>`__.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unclear why we would change this link. It is not broken.

Issues are much more likely to be resolved if others can reproduce them easily.

- Mention troubleshooting steps that have been tried already, including:
Expand Down