-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: fix broken external links in tutorial and developer guide pages #7032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ It also generates code for converting ROS message structures to and from DDS mes | |
| This generator is also responsible for creating a shared library for the message package it is being used in, which is specific to the messages in the message package and to the DDS vendor being used. | ||
|
|
||
| As mentioned above, the ``rosidl_typesupport_introspection_<language>`` may be used instead of a vendor specific type support package if an RMW implementation supports runtime interpretation of messages. | ||
| This ability to programmatically send and receive types over topics without generating code beforehand is achieved by supporting the `DDS X-Types Dynamic Data standard <https://www.omg.org/spec/DDS-XTypes/>`_. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here, https://www.omg.org/spec/DDS-XTypes/ is not a broken link? |
||
| This ability to programmatically send and receive types over topics without generating code beforehand is achieved by supporting the `DDS X-Types Dynamic Data standard <https://www.omg.org/spec/DDS-XTypes/About-DDS-XTypes/>`_. | ||
| As such, RMW implementations may provide support for the X-Types standard, and/or provide a package for type support generated at compile time specific to their DDS implementation. | ||
|
|
||
| For examples of example of DDS RMW implementation repositories, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ We will then simulate a lossy network connection between them and show how diffe | |
| Prerequisites | ||
| ------------- | ||
| This tutorial assumes you have a :doc:`working ROS 2 installation <../../../../Get-Started/Installation>` and OpenCV. | ||
| See the `OpenCV documentation <http://docs.opencv.org/doc/tutorials/introduction/table_of_content_introduction/table_of_content_introduction.html#table-of-content-introduction>`__ for its installation instructions. | ||
| See the `OpenCV documentation <https://docs.opencv.org/4.x/>`__ for its installation instructions. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://docs.opencv.org/5.0/ ? why 4.x? |
||
| You will also need the ROS package ``image_tools``. | ||
|
|
||
| .. tabs:: | ||
|
|
@@ -157,7 +157,7 @@ Add network traffic | |
|
|
||
| However, for macOS and Windows you can achieve a similar effect with the utilities "Network Link Conditioner" (part of the xcode tool suite) and `"Clumsy" <http://jagt.github.io/clumsy/index.html>`_, respectively, but they will not be covered in this tutorial. | ||
|
|
||
| We are going to use the Linux network traffic control utility, ``tc`` (`man page <http://linux.die.net/man/8/tc>`_) . | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not broke link. |
||
| We are going to use the Linux network traffic control utility, ``tc`` (`man page <https://man7.org/linux/man-pages/man8/tc.8.html>`_) . | ||
|
|
||
| .. code-block:: console | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -153,7 +153,7 @@ Change control process | |
|
|
||
| * You can pass ``-s`` / ``--signoff`` to the ``git commit`` invocation or write the expected message manually (e.g. ``Signed-off-by: Your Name Developer <your.name@example.com>``). | ||
|
|
||
| * DCO is *not* required for pull requests that only address whitespace removal, typo correction, and other `trivial changes <http://cr.openjdk.java.net/~jrose/draft/trivial-fixes.html>`_. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here , this is not broken link. |
||
| * DCO is *not* required for pull requests that only address whitespace removal, typo correction, and other `trivial changes <https://openjdk.org/bylaws#trivial-change>`_. | ||
|
|
||
| * Always run CI jobs for all `tier 1 platforms <https://reps.openrobotics.org/rep-2000/#support-tiers>`_ for every pull request and include links to jobs in the pull request. | ||
| (If you don't have access to the Jenkins jobs someone will trigger the jobs for you.) | ||
|
|
@@ -294,7 +294,7 @@ When filing an issue please make sure to: | |
| Reasoning: This helps us narrow down the layer in the stack at which the issue might be. | ||
|
|
||
| - Include a list of steps to reproduce the issue. | ||
| - In case of a bug consider to provide a `short, self contained, correct (compilable), example <http://sscce.org/>`__. | ||
| - In case of a bug consider to provide a `short, self contained, correct (compilable), example <https://stackoverflow.com/help/minimal-reproducible-example>`__. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a little unclear why we would change this link. It is not broken. |
||
| Issues are much more likely to be resolved if others can reproduce them easily. | ||
|
|
||
| - Mention troubleshooting steps that have been tried already, including: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gazebosim.org/home is not broken link?