Skip to content

Add a check for the MSVC is properly installed - #7046

Open
knmcguire wants to merge 9 commits into
ros2:rollingfrom
knmcguire:patch-3
Open

Add a check for the MSVC is properly installed#7046
knmcguire wants to merge 9 commits into
ros2:rollingfrom
knmcguire:patch-3

Conversation

@knmcguire

Copy link
Copy Markdown
Contributor

Description

This add instructions to check if the VSstudio has been properly installed. Many times MSVC is not finished installing but people (absolutely asking for a friend), then go straight to colcon build. This not only will fail as the C/C++compiler is usually not installed but will also break the installation which needs to be repaired.

Did you use Generative AI?

Yes but only as in browser sparring partner on this. So the checking command is generated by it but I have written the rest of the instructions myself.

I used Claude Opus 4.8

Additional Information

@kscottz kscottz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One (optional) minor suggestion.

Comment thread source/Get-Started/Installation/Alternatives/Windows-Development-Setup.rst Outdated
…nt-Setup.rst

Co-authored-by: Katherine Scott <katherineAScott@gmail.com>
Signed-off-by: Kimberly N. McGuire <kimberleymcguire@gmail.com>
Comment thread source/Get-Started/Installation/Alternatives/Windows-Development-Setup.rst Outdated
Signed-off-by: Kimberly N. McGuire <kimberleymcguire@gmail.com>
@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Waiting for any of
  • check-neutral = build
  • check-skipped = build
  • check-success = build
All conditions
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • any of [🛡 GitHub branch protection]:
        • check-neutral = build
        • check-skipped = build
        • check-success = build
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • github-require-last-push-approval [🛡 GitHub branch protection]
      • github-review-approved [🛡 GitHub branch protection]
      • any of [🛡 GitHub branch protection]:
        • check-success = lint
        • check-neutral = lint
        • check-skipped = lint
      • any of [🛡 GitHub branch protection]:
        • check-success = test
        • check-neutral = test
        • check-skipped = test
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

queue

⚠️ Configuration not compatible with a branch protection setting

Details

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants