Replace deprecated spin_until_future_complete#2
Replace deprecated spin_until_future_complete#2hliberacki wants to merge 1 commit intoros2:rollingfrom
Conversation
|
Due to change in RCLCPP - ros2/rclcpp#1874 Pull request |
|
Thanks for the PR @hliberacki! Since this GitHub repo is just a mirror, do you mind moving this to the GitLab repo? https://gitlab.com/ros-tracing/ros2_tracing If not, I can do it! |
|
@christophebedard I wasn't aware of that :) good to know. Yes, I can move it to GitLab no problem - yet I will be able to do it later today (in 3-4 hours from now, since I am off my PC at the moment). If you'd like to have it quicker and be kind enough to do it for me, it would be great as well :) |
|
I opened a merge request with your commit here: https://gitlab.com/ros-tracing/ros2_tracing/-/merge_requests/291. I'll close this PR now. |
|
Re-opening this since the repo was moved to GitHub. |
christophebedard
force-pushed
the
hliberacki/spin_until
branch
2 times, most recently
from
f145774 to
ef43eb4
Compare
|
Test failures are due to #27 |
christophebedard
changed the title
spin_until_future_completespin_until_future_complete
christophebedard
force-pushed
the
hliberacki/spin_until
branch
from
ef43eb4 to
13dcc56
Compare
|
I re-targeted the PR from |
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp> Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
I believe that g++ does not guarantee what a particular symbol name will be. Thus, in g++ 11.4.0 (what is in Ubuntu 22.04), the symbol name here ended with "#2", while in g++ 13.2.0 (what is in Ubuntu 24.04), the symbol name ends with "#1". Given that we can't guarantee this, just search for the first part of the name up to the number, which should be good enough for this test. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
* Use a memcmp for the expected symbol name. I believe that g++ does not guarantee what a particular symbol name will be. Thus, in g++ 11.4.0 (what is in Ubuntu 22.04), the symbol name here ended with "#2", while in g++ 13.2.0 (what is in Ubuntu 24.04), the symbol name ends with "#1". Given that we can't guarantee this, just search for the first part of the name up to the number, which should be good enough for this test. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
…ete` Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
christophebedard
force-pushed
the
hliberacki/spin_until
branch
from
13dcc56 to
7c14027
Compare
christophebedard
changed the title
spin_until_future_complete
christophebedard
changed the title
|
As per the discussion in ros2/rclcpp#2475 (comment), we will not be doing this. Closing. |
4 participants
Replace deprecated
spin_until_future_completewithspin_until_completeSigned-off-by: Hubert Liberacki hliberacki@gmail.com
action-ros-ci-repos-override: https://gist.githubusercontent.com/christophebedard/11821dfe3c6bc30740424e3f1aadc00a/raw/c89766f8e94f902dc1845a774eb0073f7eabcf10/ros2.repos