Rainbow Effect - #38
Open
A5ho9999 wants to merge 2 commits into
Open
Conversation
eristhea
self-requested a review
June 26, 2025 01:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a rainbow effect system to create RGB on entities.
Right now supports just a name, but would recommend using a variant or other way like a dye item as naming would prevent people from actually naming it what they want.
ColorOverlayVertexConsumer may need double checking, I think I got the methods right but with the mappings it is honestly hard to tell.
edit: I did this before I noticed there was a recent change lol