Harden cluster bus packet framing - #28
Draft
roshkhatri wants to merge 1 commit into
Draft
Conversation
roshkhatri
force-pushed
the
cluster-bus-packet-hardening
branch
from
August 11, 2026 21:15
e030e77 to
7227d07
Compare
Signed-off-by: Roshan Khatri <roshanvkhatri@gmail.com>
roshkhatri
force-pushed
the
cluster-bus-packet-hardening
branch
from
August 11, 2026 22:08
7227d07 to
c977e0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens cluster-bus packet framing and PING extensions independently of the variable payload validation tracked in valkey-io#3972.
Findings
Fix
Compatibility
Peers that advertise packets larger than 16 MiB are rejected. New senders enforce the same limit and return explicit errors instead of generating packets receivers reject.
Scope
This PR intentionally excludes inbound
PUBLISH,PUBLISHSHARD, andMODULEpayload-consistency checks owned by valkey-io#3972.Validation
git diff --checkand clang-format 18 source checks passed.Draft in the fork for manual security and compatibility review.