Fix crash on assigning military equip without current goal#89
Open
queria wants to merge 1 commit into
Open
Conversation
When Settler does not have current goal (like hauling something),
when switched to military and assigning equipment (armor/weapon...),
game would crash when attempting to compare if current goal is not
already to fetch the equipment due to the settler not having any goal.
(Not sure if it can happen normally, but easy to reproduce
using debug menu, when in paused state, by spawning settler,
switching to military and assigning from available equip).
Trace (part, and from Steam version) looks as:
```
ERROR: java.lang.NullPointerException: Cannot invoke "technology.rocketjump.mountaincore.entities.ai.goap.AssignedGoal.getAssignedHaulingAllocation()"
because the return value of "technology.rocketjump.mountaincore.entities.behaviour.creature.CreatureBehaviour.getCurrentGoal()" is null
at technology.rocketjump.mountaincore.entities.components.creature.MilitaryComponent.getCurrentHaulingAllocation(MilitaryComponent.java:180)
at technology.rocketjump.mountaincore.entities.components.creature.MilitaryComponent.createHaulingAllocationIfRequired(MilitaryComponent.java:161)
at technology.rocketjump.mountaincore.entities.components.creature.MilitaryComponent.infrequentUpdate(MilitaryComponent.java:104)
at technology.rocketjump.mountaincore.screens.SettlerManagementScreen.lambda$weaponSelection$10(SettlerManagementScreen.java:575)
at technology.rocketjump.mountaincore.screens.SettlerManagementScreen$9.lambda$clicked$2(SettlerManagementScreen.java:605)
at technology.rocketjump.mountaincore.screens.SettlerManagementScreen$SelectItemOption.onSelect(SettlerManagementScreen.java:806)
at technology.rocketjump.mountaincore.ui.widgets.SelectItemDialog$1.clicked(SelectItemDialog.java:68)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Settler does not have current goal (like hauling something), when switched to military and assigning equipment (armor/weapon...), game would crash when attempting to compare if current goal is not already to fetch the equipment due to the settler not having any goal.
(Not sure if it can happen normally, but easy to reproduce
using debug menu, when in paused state, by spawning settler,
switching to military and assigning from available equip).
Trace (part, and from Steam version) looks as: