Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of changes
Enhances testing of the confire package.
Type of change
Author checklist
Note
Medium Risk
Medium risk because it changes validation gathering/flattening (including struct-level
Validate()support) and adds new public error-introspection helpers that could affect error types/order observed by callers.Overview
Adds a new
contest.Envtest helper to set/clear scoped environment variables with automatic restoration, along with newasserthelpers (NotOkplus environment assertions) and README documentation for using them.Expands validation behavior by allowing the root spec to implement
validate.Validator, and by flattening/normalizing nestederrors.ValidationErrorsinto a consistent list; the top-levelconfirepackage now exposesValidationErrors()andIsValidationErrors()helpers to inspect those errors. Includes new end-to-end tests (confire_test.go) covering env loading, defaults, and multi-error validation output ordering.Written by Cursor Bugbot for commit a5e0d8c. Configure here.