Skip to content

[FEAT] Dockerfile#3

Merged
bbengfort merged 1 commit intomainfrom
docker
Mar 30, 2026
Merged

[FEAT] Dockerfile#3
bbengfort merged 1 commit intomainfrom
docker

Conversation

@bbengfort
Copy link
Copy Markdown
Contributor

@bbengfort bbengfort commented Mar 30, 2026

Scope of changes

Implements container and container build process for the service.

Estimated PR Size:

  • Tiny
  • Small
  • Medium
  • Large
  • Huge

Acceptance criteria

This PR will be merged without review.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have added new test fixtures as needed to support added tests
  • I have added or updated the documentation
  • I have run go generate to update generated code

Note

Medium Risk
Introduces new CI/CD automation that builds and pushes images using registry credentials and new build args; failures or misconfiguration could block releases or publish incorrect tags.

Overview
Adds first-class containerization for the uptime service via a new multi-stage Dockerfile that builds a static binary and injects GitVersion/BuildDate via -ldflags.

Introduces a new .github/workflows/containers.yaml workflow to build multi-arch images on pushes/tags, generate semver/SHA tags, and push to DockerHub and GCR (pushes disabled on PRs) using repository secrets.

Written by Cursor Bugbot for commit 15f281a. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

- name: Set Environment
id: vars
run: |
echo "tag=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused tag output variable in workflow step

Low Severity

The tag output computed in the Set Environment step is never referenced anywhere in the workflow. Only revision and build_date are consumed (via steps.vars.outputs.revision and steps.vars.outputs.build_date). The tag output is dead code that adds confusion about whether something downstream was supposed to use it.

Fix in Cursor Fix in Web

@bbengfort bbengfort merged commit 7ecbf04 into main Mar 30, 2026
5 checks passed
@bbengfort bbengfort deleted the docker branch March 30, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant