Conversation
Pin all actions to commit SHAs, update pnpm/action-setup to v5 and upload-artifact to v7, add least-privilege permissions, concurrency groups, and simplify caching via setup-node's built-in pnpm cache. Also pin changelogithub to v14.0.0 and enable pinGitHubActionDigests in Renovate.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
kelsos
force-pushed
the
feat/modernize-build
branch
2 times, most recently
from
e713362 to
79c4e21
Compare
Add pnpm-workspace.yaml with security hardening (blockExoticSubdeps, strictDepBuilds, trustPolicy, saveExact) and update Renovate to pin all dependencies and enforce 7-day minimum release age.
Replace @vercel/ncc (webpack) with Rollup for bundling. Switch to ESM with "type": "module", update tsconfig to ES2022 target with Bundler module resolution, and upgrade @actions/core to v3. Remove intermediate lib/ build step — Rollup bundles directly from TypeScript source.
kelsos
force-pushed
the
feat/modernize-build
branch
from
79c4e21 to
3adfda9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup-node's built-in pnpm cachepnpm-workspace.yamlwithblockExoticSubdeps,strictDepBuilds,trustPolicy,saveExact:pinAllExceptPeerDependencies,helpers:pinGitHubActionDigests, and 7-day minimum release ageeslint-plugin-github: Browser-oriented rules not applicable to a Node action, and causes exotic subdep issues with pnpm hardening@rotki/eslint-configv5 and@rotki/eslint-plugin1.3.2@vercel/ncc(webpack) with Rollup, ESM output, ES2022 target, Bundler module resolution@actions/coreto v3bumppto v11, pnpm to 10.33.0Test plan
pnpm run allpasses (build, lint, package, test)uses: ./integration test passes in CI