feat(date-time-picker): expose v-model:menu-open#522
Merged
kelsos merged 1 commit intorotki:mainfrom Apr 28, 2026
Merged
Conversation
Lets parent overlays read whether any teleported sub-overlay (the picker menu itself or its calendar month/year sub-menu) is open, so they can bind :persistent during that window instead of forcing it on always. Closes rotki#516.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
+ Coverage 84.88% 84.89% +0.01%
==========================================
Files 143 143
Lines 5213 5217 +4
Branches 1553 1554 +1
==========================================
+ Hits 4425 4429 +4
Misses 788 788 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v-model:menu-openonRuiDateTimePickerthat mirrorsisOpen || calendarMenuOpen— true whenever any of the picker's teleported overlays (its own menu or the calendar's month/year sub-menu) is open.RuiMenu/RuiDialogwrappers bind:persistentonly for that window instead of forcing it on always.InsideParentMenuand an example-app fixture demonstrate the pattern.Closes #516. Unblocks rotki/rotki#12091 (
CalendarDateNavigatorGo-to-date dropdown can drop its manual:persistent+ ESC workaround).Test plan
RuiDateTimePicker.spec.tscovers picker-menu open/close emit and "stays open while sub-menu opens after picker is open".apps/example/e2e/datetimepicker.spec.tscovers (1) parent stays open while only picker menu open, (2) parent stays open while sub-menu open, (3) parent closes when no picker overlay is open.pnpm run typecheck/pnpm run lint/pnpm run test:run(1072 pass) /pnpm run test:e2e(3 new + existing pass) /pnpm run build:prodgreen.web-types.jsonexposesmenu-open+update:menuOpen.Follow-up
A
lu-calendar-daysruntime warning shows up in the example app because the icon plugin auto-detects only consumer source. The picker stack's icons should be registered library-side (build-time emit + plugin baseline) so every consumer gets them for free. Will be a separate PR.