Skip to content

fix(forms): wire hover border on activator-based inputs#529

Merged
kelsos merged 1 commit intorotki:mainfrom
kelsos:fix/activator-hover-border
Apr 29, 2026
Merged

fix(forms): wire hover border on activator-based inputs#529
kelsos merged 1 commit intorotki:mainfrom
kelsos:fix/activator-hover-border

Conversation

@kelsos
Copy link
Copy Markdown
Member

@kelsos kelsos commented Apr 29, 2026

Summary

  • RuiAutoComplete, RuiMenuSelect, and RuiDateTimePicker share activatorStyles, which already defines an outlined + hovered border rule, but none of them tracked the hover state — so the hover-border-darken behavior present in RuiTextField/RuiTextArea was missing.
  • Track isHovered via mouseenter/mouseleave on each activator and pass it into ui().
  • Re-declare the hovered variant in activatorStyles for type inference, mirroring the existing filled re-declaration.

Test plan

  • pnpm typecheck
  • pnpm lint
  • pnpm test:run for AutoComplete / MenuSelect / DateTimePicker
  • Visual: hover the outlined variant of each component and confirm the border darkens (matching RuiTextField/RuiTextArea), and that the focus/error/success states still take precedence.

RuiAutoComplete, RuiMenuSelect, and RuiDateTimePicker share
activatorStyles which already defines an outlined+hovered border
rule, but none of the three components tracked the hover state, so
the border-darken-on-hover behavior present in RuiTextField and
RuiTextArea was missing for these inputs.

Track isHovered via mouseenter/mouseleave on each activator and pass
it into the styles. Re-declare the hovered variant in activatorStyles
for type inference, mirroring the existing filled re-declaration.
@kelsos kelsos requested a review from a team as a code owner April 29, 2026 14:10
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.83%. Comparing base (34a0ef1) to head (a91632b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   84.79%   84.83%   +0.04%     
==========================================
  Files         145      145              
  Lines        5260     5269       +9     
  Branches     1571     1577       +6     
==========================================
+ Hits         4460     4470      +10     
+ Misses        800      799       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelsos kelsos merged commit a91632b into rotki:main Apr 29, 2026
5 checks passed
@kelsos kelsos deleted the fix/activator-hover-border branch April 29, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants