feat: add public RuiTimezoneSelect component#531
Open
kelsos wants to merge 3 commits intorotki:mainfrom
Open
Conversation
Previously the Playwright container ran as root by default, so any files written into the bind-mounted repo (dist/, test-results/, playwright- report/) became root-owned and broke subsequent local pnpm builds and e2e runs with EACCES. Pass --user $UID:$GID and point HOME at /tmp so corepack/pnpm caches stay writable.
Extract the timezone autocomplete that was previously inlined inside RuiDateTimePickerMenu into its own public component so it can be used standalone. Display labels render with underscores replaced by spaces (e.g. America/New York) while the v-model keeps the canonical IANA string. Includes Storybook stories, unit tests, an example route, and Playwright e2e coverage. RuiDateTimePickerMenu now consumes the new component.
These canonical IANA zones (added in tzdata 2022g and 2024b) were
missing from our list. Verified against Intl.supportedValuesOf('timeZone')
that no other canonical zones are missing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
+ Coverage 84.83% 84.84% +0.01%
==========================================
Files 145 146 +1
Lines 5267 5271 +4
Branches 1577 1578 +1
==========================================
+ Hits 4468 4472 +4
Misses 799 799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuiDateTimePickerMenuinto its own publicRuiTimezoneSelectcomponent, so consumers can use it standalone.America/New York) whilev-modelkeeps the canonical IANA string (America/New_York).America/Ciudad_JuarezandAmerica/Coyhaiqueto the timezones list — verified againstIntl.supportedValuesOf('timeZone')that no other canonical IANA zones were missing./timezone-selects, and Playwright e2e coverage.RuiDateTimePickerMenunow consumes the new component.apps/example/scripts/visual-docker.shnow passes--user $UID:$GIDand pointsHOMEat/tmpso files written into the bind-mounted repo (dist/, test-results/, baselines, etc.) stay owned by the host user instead of root.Test plan
pnpm lint— 0 errorspnpm typecheck— cleanpnpm build:prod— cleanpnpm test:ci— 1088/1088 unit tests passpnpm test:e2e— 293/293 e2e tests pass (incl. 8 newtimezone-selecttests)pnpm test:visual) on a clean machine to confirm the docker--userflag works for contributors who don't yet have root-owned artefacts