Skip to content

Cleanup #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
everythingfunctional wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Cleanup #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
06e22db
chore: delete commented out code and noise comments
everythingfunctional Jul 21, 2021
77819e8
chore: delete unused variables, parameters and arguments identified b…
everythingfunctional Jul 21, 2021
3721f6a
chore(thompson_init): remove arguments
everythingfunctional Jul 21, 2021
3e75d29
chore: delete is_aerosol_aware and dead code
everythingfunctional Jul 21, 2021
bb31de1
chore: remove newly revealed unused variables and arguments
everythingfunctional Jul 21, 2021
d1741ae
chore: remove additional unused variables and subroutine
everythingfunctional Jul 21, 2021
7d71fa4
chore(mp_gt_driver): remove unused optional arguments
everythingfunctional Jul 21, 2021
3196a17
chore: make procedures private by default
everythingfunctional Jul 21, 2021
8f41c99
chore: delete logical parameters
everythingfunctional Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/physics/mp_driver.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ module module_mp_driver
use domain_interface, only: domain_t
use module_mp_thompson, only: thompson_init, mp_gt_driver

private
public :: microphysics

logical :: initialized = .false.
contains

subroutine mp_init(domain)
subroutine mp_init()
implicit none
type(domain_t), intent(inout) :: domain

call thompson_init()

Expand Down Expand Up @@ -39,9 +41,8 @@ subroutine process_subdomain(domain, dt, its,ite, jts,jte, kts,kte)
RAINNC=domain%accumulated_precipitation,&
SNOWNC=domain%accumulated_snowfall, &
has_reqc=0, has_reqi=0, has_reqs=0, &
ids=domain%ids,ide=domain%ide, & ! domain dims
jds=domain%jds,jde=domain%jde, &
kds=domain%kds,kde=domain%kde, &
ide=domain%ide, & ! domain dims
jde=domain%jde, &
ims=domain%ims,ime=domain%ime, & ! memory dims
jms=domain%jms,jme=domain%jme, &
kms=domain%kms,kme=domain%kme, &
Expand Down Expand Up @@ -98,7 +99,7 @@ subroutine microphysics(domain, dt, halo, subset)
real, intent(in) :: dt
integer, intent(in), optional :: halo, subset

if (.not.initialized) call mp_init(domain)
if (.not.initialized) call mp_init()

if (present(subset)) then
call process_subdomain(domain, dt, &
Expand Down Expand Up @@ -130,9 +131,8 @@ subroutine microphysics(domain, dt, halo, subset)
RAINNC=domain%accumulated_precipitation,&
SNOWNC=domain%accumulated_snowfall, &
has_reqc=0, has_reqi=0, has_reqs=0, &
ids=domain%ids,ide=domain%ide, & ! domain dims
jds=domain%jds,jde=domain%jde, &
kds=domain%kds,kde=domain%kde, &
ide=domain%ide, & ! domain dims
jde=domain%jde, &
ims=domain%ims,ime=domain%ime, & ! memory dims
jms=domain%jms,jme=domain%jme, &
kms=domain%kms,kme=domain%kme, &
Expand Down
Loading