fix: preserve ROUTATIC_PROXY_* env vars in launchd autostart

[stefanoverna]

What

The launchd plist generated by autostart enable didn't include environment variables. When the proxy was started via launchd (e.g., at login), it would launch without ROUTATIC_PROXY_API_KEY and other configuration from the user's environment.

Fix

Added ExtraEnv to the plist template and populate it from the current process environment, filtering for ROUTATIC_PROXY_* variables.

Testing

• All daemon tests pass
• Manually verified plist contains env vars after autostart enable

[kilo-code-bot]

Code Review Roast 🔥

Verdict: No Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are.

Files Reviewed (2 files)

• internal/daemon/autostart_darwin.go - previously reviewed, issues fixed
• internal/daemon/autostart_darwin_test.go - previously reviewed, issues fixed

Previous Review Summary (commit d13ef67)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit d13ef67)

Verdict: 2 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
🚨 critical	0
⚠️ warning	1
💡 suggestion	1
🤏 nitpick	0

Issue Details (click to expand)

File	Line	Roast
internal/daemon/autostart_darwin.go	59	text/template doesn't XML-escape env var values; a stray & in an API key bricks the plist
internal/daemon/autostart_darwin_test.go	43	Test doesn't actually set or verify ROUTATIC_PROXY_* env vars in the generated plist

---

🏆 Best part: The test fix is honest — they caught that the test was claiming serve while the template had start --background all along. Refreshing to see someone admit a test was wrong.

💀 Worst part: Inserting unescaped user-controlled strings into XML with text/template. One & in an env var value turns launchd into a very confused mess.

📊 Overall: Like ordering pizza and only getting the box. You got a box of XML. But where's my actual env var validation?

Files Reviewed (2 files)

• internal/daemon/autostart_darwin.go - 1 warning
• internal/daemon/autostart_darwin_test.go - 1 suggestion

Fix these issues in Kilo Cloud

---

_{Reviewed by step-3.7-flash · Input: 59.9K · Output: 8.6K · Cached: 160.6K}

_{Review guidance: REVIEW.md from base branch main (truncated)}

[stefanoverna]

All issues addressed:

1. XML escaping → fixed: added xmlEscape template function using html.EscapeString. Env var values with &, <, > are now properly escaped in the plist.
2. Test coverage → fixed: test now sets ROUTATIC_PROXY_API_KEY=sk-test&key<value> and asserts the plist contains the XML-escaped equivalent sk-test&key<value>.

All 8 daemon tests pass.

[samueltuyizere]

LGTM!