fix(claude-auth): support HTTP proxy for OAuth refresh#2097
fix(claude-auth): support HTTP proxy for OAuth refresh#2097abix5 wants to merge 4 commits intorouter-for-me:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves issues related to Anthropic OAuth/authentication refresh failures when a proxy configuration is in use. It introduces robust proxy handling capabilities, ensuring that authentication requests can be successfully routed through various proxy types, thereby improving the reliability of Claude API interactions in proxied environments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for HTTP proxies for Claude authentication, including http, https, and socks5 schemes. The implementation correctly handles HTTP CONNECT tunneling for http/https proxies, which was a limitation in the previous approach. The new functionality is well-tested with a new suite of focused unit and integration tests. The changes are clean and effectively address the issue of proxy support for OAuth refresh.
My review includes a few suggestions to improve error handling in the proxy dialer and to make the test mocks more robust by using standard library functions for parsing HTTP requests instead of manual parsing. These changes will improve the maintainability and correctness of the code and its tests.
|
Addressed Gemini review suggestions in follow-up commits.
Validation completed:
|
Summary
http,https,socks5, andsocks5hproxy schemes.proxy-url: http://...works in the uTLS refresh path.newUtlsRoundTripperto use the new dialer and improve proxy dialer error logging context.Testing
go test -race -count=1 ./internal/auth/claude/go test ./...Context