feat(service): extend model registration for team and business types

[hkfires]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the model registration service by aligning the business account type with the team account type. This change ensures that users with a business subscription will now correctly access the CodexTeamModels, standardizing model availability across similar subscription tiers.

Highlights

• Model Registration: The model registration logic for the team account type has been extended to also apply to the business account type, ensuring both utilize GetCodexTeamModels().

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdk/cliproxy/service.go
  • Extended the switch statement in registerModelsForAuth to include the "business" case alongside "team" for GetCodexTeamModels.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request extends the model registration for Codex to include the 'business' plan type, treating it the same as the 'team' plan type. The change is straightforward and correct. My main feedback is to add a unit test to cover this new logic to prevent future regressions and ensure maintainability.

[gemini-code-assist]

While this change correctly handles the 'business' plan type, this part of the model registration logic appears to be untested. To ensure the correctness of this new addition and prevent future regressions, it would be beneficial to add a unit test.

You could create a test that:

1. Initializes a Service.
2. Creates a coreauth.Auth object with Provider: "codex" and Attributes: map[string]string{"plan_type": "business"}.
3. Calls service.registerModelsForAuth() with this auth object.
4. Asserts that the models from registry.GetCodexTeamModels() are registered for the auth ID in the GlobalModelRegistry().

This would provide good test coverage for the change.