Skip to content

fix(codex): translate service_tier "fast" to "priority" instead of stripping it #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ynlmz wants to merge 1 commit into from
Closed

fix(codex): translate service_tier "fast" to "priority" instead of stripping it #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/translator/codex/openai/responses/codex_openai-responses_request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ func ConvertOpenAIResponsesRequestToCodex(modelName string, inputRawJSON []byte,
rawJSON, _ = sjson.SetBytes(rawJSON, "store", false)
rawJSON, _ = sjson.SetBytes(rawJSON, "parallel_tool_calls", true)
rawJSON, _ = sjson.SetBytes(rawJSON, "include", []string{"reasoning.encrypted_content"})
// Codex Responses rejects token limit fields, so strip them out before forwarding.
if v := gjson.GetBytes(rawJSON, "service_tier"); v.Exists() && v.String() == "fast" {
rawJSON, _ = sjson.SetBytes(rawJSON, "service_tier", "priority")
}
Comment on lines +23 to +25
Copy link

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability and maintainability, consider extracting the magic strings "service_tier", "fast", and "priority" into named constants defined at the package level.

For example:

const (
    serviceTierField         = "service_tier"
    openAIServiceTierFast    = "fast"
    codexServiceTierPriority = "priority"
)

Then you can use these constants here:

if v := gjson.GetBytes(rawJSON, serviceTierField); v.Exists() && v.String() == openAIServiceTierFast {
    rawJSON, _ = sjson.SetBytes(rawJSON, serviceTierField, codexServiceTierPriority)
}

// Codex Responses rejects token limit and sampling fields, so strip them out before forwarding.
rawJSON, _ = sjson.DeleteBytes(rawJSON, "max_output_tokens")
rawJSON, _ = sjson.DeleteBytes(rawJSON, "max_completion_tokens")
rawJSON, _ = sjson.DeleteBytes(rawJSON, "temperature")
rawJSON, _ = sjson.DeleteBytes(rawJSON, "top_p")
rawJSON, _ = sjson.DeleteBytes(rawJSON, "service_tier")
rawJSON, _ = sjson.DeleteBytes(rawJSON, "truncation")
rawJSON = applyResponsesCompactionCompatibility(rawJSON)

Expand Down