Skip to content

Struct attrributes#268

Draft
yfukai wants to merge 18 commits intoroyerlab:mainfrom
yfukai:struct_attr
Draft

Struct attrributes#268
yfukai wants to merge 18 commits intoroyerlab:mainfrom
yfukai:struct_attr

Conversation

@yfukai
Copy link
Contributor

@yfukai yfukai commented Feb 20, 2026

Partially solves #194 by allowing pl.Struct saved and searched in graphs.
Assumes #262 merged.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 76.11465% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.02%. Comparing base (e4bb183) to head (19055ab).

Files with missing lines Patch % Lines
src/tracksdata/graph/_sql_graph.py 80.12% 20 Missing and 13 partials ⚠️
src/tracksdata/utils/_dtypes.py 72.60% 11 Missing and 9 partials ⚠️
src/tracksdata/attrs.py 72.72% 10 Missing and 2 partials ⚠️
src/tracksdata/graph/_rustworkx_graph.py 56.52% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   87.92%   87.02%   -0.90%     
==========================================
  Files          56       56              
  Lines        4471     4741     +270     
  Branches      789      844      +55     
==========================================
+ Hits         3931     4126     +195     
- Misses        344      395      +51     
- Partials      196      220      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yfukai yfukai marked this pull request as ready for review February 26, 2026 02:51
@yfukai yfukai mentioned this pull request Feb 26, 2026
8 tasks
@yfukai yfukai marked this pull request as draft February 26, 2026 03:14
@yfukai
Copy link
Contributor Author

yfukai commented Feb 26, 2026

Maybe I should save the data field-wise in SQLGraph. Let me experiment in this way.

@JoOkuma
Copy link
Member

JoOkuma commented Feb 27, 2026

@yfukai, let me know when this is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants