feat(core): add Kimi Code CLI platform support#90
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds support for the Kimi Code AI coding platform by introducing its platform definition with skills directory configuration, mapping it to the kimi-code-cli agent, and extending detection, initialization, and OpenSpec tests to verify correct handling. Documentation and CI workflows are updated to reflect 29 supported platforms. ChangesKimi Code Platform Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/ts/detect.test.ts (1)
92-92: ⚡ Quick winUse exact detected count in this deterministic test.
tmpDiris controlled and only three platform dirs are created in this case, sotoBe(3)will catch accidental over-detection better thantoBeGreaterThanOrEqual(3).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/ts/detect.test.ts` at line 92, The test assertion is nondeterministic; replace the loose check expect(detected.size).toBeGreaterThanOrEqual(3) with an exact assertion expect(detected.size).toBe(3) so the deterministic setup (three platform dirs in tmpDir) fails on accidental over-detection; update the assertion in test/ts/detect.test.ts where the variable detected is checked.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/ts/detect.test.ts`:
- Line 92: The test assertion is nondeterministic; replace the loose check
expect(detected.size).toBeGreaterThanOrEqual(3) with an exact assertion
expect(detected.size).toBe(3) so the deterministic setup (three platform dirs in
tmpDir) fails on accidental over-detection; update the assertion in
test/ts/detect.test.ts where the variable detected is checked.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5596469a-6c68-4fa7-9bbb-effe57b94f0b
📒 Files selected for processing (10)
.github/workflows/ci.ymlREADME-zh.mdREADME.mdsrc/core/platforms.tssrc/core/superpowers.tstest/ts/ci-workflows.test.tstest/ts/detect.test.tstest/ts/init-e2e.test.tstest/ts/openspec.test.tstest/ts/superpowers.test.ts
|
LGTM |
✨ Summary
🎯 Scope
init,status,doctor,update)assets/skills/,assets/skills-zh/)assets/skills/comet/scripts/)🧪 Testing
pnpm buildpnpm lintpnpm format:checkpnpm testpnpm test -- test/ts/comet-scripts.test.tspnpm test:shell✅ Checklist
fix: handle project-scope initREADME.md,README-zh.md, orCONTRIBUTING.mdCHANGELOG.mdis updated when behavior changesassets/manifest.jsonand relevant tests👀 Notes for Reviewers
Summary by CodeRabbit
New Features
Documentation
Tests / CI