cosmic changes#74
Draft
robtfm wants to merge 18 commits intorparrett:mainfrom
Draft
Conversation
Contributor
Author
Recording.2024-08-30.142832.mp4 |
Owner
|
Lovely, thank you! I was playing around with this a bit with https://github.com/rparrett/bevy_simple_text_input/tree/bevy_main as a base earlier, but really wasn't liking how it was going. I was referencing https://github.com/tigregalis/bevy_text_editor, but your implementation retaining an Editor seems way nicer. |
Contributor
Author
|
it does require copying the buffer (though using the lazy init, only when needed)... but it seems bevy does this internally for perhaps cosmic's |
Owner
|
tigregalis had some ideas over here: pop-os/cosmic-text#285 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not to be merged as is, but in case it's useful as a starting point for you in the future.
here i have modifications to support bevy 0.14 with bevy#10193 (cosmic text) cherry picked in.
i added floating cursor, selection management, undo/redo and cut/copy/paste (on a feature flag for clipboard integration - it might be nice to allow some other non-system-clipboard support via resources/events but i don't need it personally).
still plan to add at least some mouse support (probably optional in settings).