Skip to content

Adding HotFix for 'not found' error #11 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdeligt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding HotFix for 'not found' error #11 #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion deepbinner/bin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ def write_read_files(reads_filename, classifications, out_filenames, input_type)
out_files = {}
for class_name, out_file in out_filenames.items():
out_files[class_name] = open(out_file, 'wt')
# HotFix: add a outfile/class_name for reads that are "not found" in classifications (see KeyError a bit down) and issue #11
out_files['not found'] = open("unfindables.txt", 'wt')

count, interval = 0, random.randint(90, 110)
with open_func(reads_filename, 'rt') as reads:
Expand Down Expand Up @@ -190,7 +192,7 @@ def print_summary_and_zip(bin_counts, out_filenames):
gzip = 'gzip'
print('Gzipping reads:')
print(' Barcode Reads File')
class_names = out_filenames.keys()
class_names = list(out_filenames.keys()) # Relates to HotFix, this wasn't working because of "'odict_keys' object has no attribute 'append'"
if 'not found' in bin_counts:
class_names.append('not found')
for class_name in class_names:
Expand Down