Added additional msgpack data types for rs.io.read_dials_stills#326
Added additional msgpack data types for rs.io.read_dials_stills#326LuisA92 wants to merge 6 commits intors-station:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 86.78% 86.78%
=======================================
Files 40 40
Lines 2837 2837
=======================================
Hits 2462 2462
Misses 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
seems reasonable to me too. Once @dermen approves, looks like a good fix to improve coverage of different |
|
For reference, the following columns from an extra_cols = [
'background.mean',
'background.sum.value',
'background.sum.variance',
'bbox',
'd',
'entering',
'flags',
'id',
'imageset_id',
'intensity.prf.value',
'intensity.prf.variance',
'intensity.sum.value',
'intensity.sum.variance',
'lp',
'miller_index',
'num_pixels.background',
'num_pixels.background_used',
'num_pixels.foreground',
'num_pixels.valid',
'panel',
'partial_id',
'partiality',
'profile.correlation',
'qe',
'refl_ids',
's1',
'xyzcal.mm',
'xyzcal.px',
'xyzobs.mm.value',
'xyzobs.mm.variance',
'xyzobs.px.value',
'xyzobs.px.variance',
'zeta',
] |
|
it's probably okay to merge this if we can't raise @dermen. it don't think it should break any of his workflows. |
kmdalton
left a comment
There was a problem hiding this comment.
this is a sensible extension that enables new machine learning applications.
|
@LuisA92 -- I think you should feel free to merge this if you're confident in it. It looks good / safe to me. |
I encountered errors when using
rs.io.read_dials_stills(extra_cols=['bbox', 'entering']). The issue is resolved by adding additional data types for the problematic columns.