Skip to content

Speed up two slowest specs (~2.2s combined) #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yahonda wants to merge 2 commits into from
+5 −5
Closed

Speed up two slowest specs (~2.2s combined) #282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb551b
Speed up threaded-cursor spec by ~1.8s
yahonda May 5, 2026
232b39d
Speed up pre-10.2 dbms_output spec by ~0.33s
yahonda May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec/plsql/schema_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,14 +255,14 @@ class TestModel < TestBaseModel
it "should safely close cursors in threaded environment" do
if (plsql.connection.database_version <=> [18, 0, 0, 0]) >= 0
expect {
t1 = Thread.new { plsql.dbms_session.sleep(1) }.tap { |t| t.abort_on_exception = true }
t2 = Thread.new { plsql.dbms_session.sleep(2) }.tap { |t| t.abort_on_exception = true }
t1 = Thread.new { plsql.dbms_session.sleep(0.1) }.tap { |t| t.abort_on_exception = true }
t2 = Thread.new { plsql.dbms_session.sleep(0.2) }.tap { |t| t.abort_on_exception = true }
[t2, t1].each { |t| t.join }
}.not_to raise_error
else
expect {
t1 = Thread.new { plsql.dbms_lock.sleep(1) }.tap { |t| t.abort_on_exception = true }
t2 = Thread.new { plsql.dbms_lock.sleep(2) }.tap { |t| t.abort_on_exception = true }
t1 = Thread.new { plsql.dbms_lock.sleep(0.1) }.tap { |t| t.abort_on_exception = true }
t2 = Thread.new { plsql.dbms_lock.sleep(0.2) }.tap { |t| t.abort_on_exception = true }
[t2, t1].each { |t| t.join }
}.not_to raise_error
end
Expand Down Expand Up @@ -352,7 +352,7 @@ class TestModel < TestBaseModel

it "should log output when database version is less than 10.2" do
allow(plsql.connection).to receive(:database_version).and_return([9, 2, 0, 0])
times = 2_000
times = 100
plsql.test_dbms_output_large("1234567890", times)
expect(@buffer.string).to eq("DBMS_OUTPUT: 1234567890\n" * times)
end
Expand Down
Loading