Skip to content

Fix response channel error handling #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjeffcaii merged 1 commit into from
Apr 29, 2026
+3 −1
Merged

Fix response channel error handling #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/transport/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ func (p *Transport) DispatchFrame(_ context.Context, frame core.BufferedFrame) (
// trigger handler
err = handler(frame)
if err != nil {
err = errors.Wrap(err, fmt.Sprintf("handle frame %s failed:", frame.Header().Type()))
err = errors.Wrap(err, fmt.Sprintf("handle frame %s failed:", t))
}
return
}
Expand Down
2 changes: 2 additions & 0 deletions internal/socket/duplex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,8 @@ func (dc *DuplexConnection) onFrameError(input core.BufferedFrame) error {
vv.pc.Error(err)
case requestChannelCallback:
vv.rcv.Error(err)
case respondChannelCallback:
vv.rcv.Error(err)
default:
return errors.Errorf("illegal value for error: %v", vv)
}
Expand Down
Loading