Added the "method" variable to addRasterImage#229
Added the "method" variable to addRasterImage#229SimonGoring wants to merge 2 commits intorstudio:masterfrom SimonGoring:master
addRasterImage#229Conversation
1. Added `method` to the options so that users can define eother `'ngb'` or `'bilinear'` options for `raster::projectExtent` to improve plotting of categorical data. (and added to `roxygen2` documentation block) 2. Do not re-project if CRS for the raster is equivalent to the current CRS. I'm not sure if this is that common an issue, but just to avoid any potential (accidental) reprojection (see issue #224).
…tion strings. The `+init=epsg:3857` projection expands to: ``` "+init=epsg:3857 +proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0 +k=1.0 +units=m +nadgrids=@null +no_defs" ``` which is not directly comparable to the variable `epsg3857`: ``` "+proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0 +k=1.0 +units=m +nadgrids=@null +no_defs" ```
|
@jcheng5 I don't see why this shouldn't be merged ? If you approve let me know and I'll give you a PR with all checks passing. |
|
I guess so. In the browser the image will be drawn with bilinear or nearest neighbor depending on zoom level. But I think that's probably fine. leaflet/inst/htmlwidgets/leaflet.js Lines 1836 to 1847 in e38c948 We will need to get a CLA from @SimonGoring. Simon, if you'll please email me at joe@rstudio.com I can send you a form. If you're not familiar with CLAs, they give the copyright of your code change to the owner of the project, so that the project can be relicensed in the future if necessary. |
|
This is such a small PR do we really need a CLA signed for this ? Other than that looks like something we should include right away. |
|
Duplicate of #462 |
3 participants
This is in reference to issues #219 and #224. I tried to figure out a way to make the direct comparison between projections, but the
epgs3857used here is not (strictly speaking) the one unpacked byrgdalwhen you use+init=epsg:3857.