docs: change (broken) Bing maps example to heatmap in {pkgdown} site#934
docs: change (broken) Bing maps example to heatmap in {pkgdown} site#934jack-davison wants to merge 5 commits intorstudio:mainfrom
Conversation
bing was broken; example taken from https://gist.github.com/jcheng5/c084a59717f18e947a17955007dc5f92
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
Thanks for the PR @jack-davison! I have just a few small comments...
vignettes/articles/extending.Rmd
Outdated
| # This tells htmlwidgets about our plugin name, version, and | ||
| # where to find the script. (There's also a stylesheet argument | ||
| # if the plugin comes with CSS files.) |
There was a problem hiding this comment.
These comments point out that the example is rather sparse and could benefit from description. Personally, I'd prefer to have these comments appear in prose rather than in comments.
There was a problem hiding this comment.
Sorry, I should have also mentioned that I don't feel particularly strongly about this. It's an obvious improvement; so if you have a stronger preference for the comments or don't have the time now I'd understand.
There was a problem hiding this comment.
I think I'd agree they'd make more sense in the body of the document rather than the comments
(they're only there because it was adapted from a gist) - I've had an initial go at moving them out into the prose, although perhaps better for someone with more clear knowledge of {htmlwidgets} to give it a crack!
There was a problem hiding this comment.
e.g., I'm not totally clear on what x and el represent in the onRender() function - although I can see they're not used in this case.
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
2 participants
Fixes #927
Briefly, this replaces the now-broken Bing 'extending Leaflet' example here with the heatmap one found at: https://gist.github.com/jcheng5/c084a59717f18e947a17955007dc5f92
Also removes a duplicate NEWs item.
Example now looks like this: