Merged
Conversation
isabelizimm
reviewed
Jul 23, 2024
isabelizimm
reviewed
Jul 23, 2024
Collaborator
isabelizimm
left a comment
isabelizimm
left a comment
There was a problem hiding this comment.
I would prefer the "reasons why" to be logged in a one issue checklist to keep this a little less verbose. But seeing everything in one place is super helpful! 🤩 Apart from that, things look good here.
Co-authored-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #250.
Similar technique used to generate the requirements file as for #254 .
I have triaged each of the rules that are disabled; it looks like some of them would be very easy to re-enable. One or two have some definite false positives and would be worth keeping disabled. The comments in
pyproject.tomlare hopefully helpful but perhaps they should be moved out of the files and into a tracking issue on GitHub.