Use context managers for opening files#335
Open
nathanjmcdougall wants to merge 1 commit intorstudio:mainfrom
Open
Use context managers for opening files#335nathanjmcdougall wants to merge 1 commit intorstudio:mainfrom
nathanjmcdougall wants to merge 1 commit intorstudio:mainfrom
Conversation
Collaborator
|
Ah, it looks like I may need to switch to a different S3 bucket. This is looking good, I'll sort out the permissions problems! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been getting
ResourceWarnings for some calls toVersion.from_filesviaboard.pin_upload. I think it's due to un-closed file managers. In this PR I just enable a Ruff rule to detect this situation, and refactor to comply with the rule.https://docs.astral.sh/ruff/rules/open-file-with-context-handler/