ci: use with-connect action for Posit Connect integration tests#351
ci: use with-connect action for Posit Connect integration tests#351isabelizimm merged 11 commits intomainfrom
with-connect action for Posit Connect integration tests#351Conversation
f0e3f9a to
d29699b
Compare
|
|
||
| dev: pins/tests/rsconnect_api_keys.json | ||
|
|
||
| dev-start: |
There was a problem hiding this comment.
Is there a way to set up with-connect locally we can add in the Makefile? like with-connect -- xyz, even if it makes assumptions about having a .lic file in a certain location or other creds.
There was a problem hiding this comment.
I added a note to CONTRIBUTING.md about how to install and run locally--is that enough or would you like a make target too? Easy enough to add one.
There was a problem hiding this comment.
On second thought I'll just do this, there is still a bit of fussing that the GHA job does to get it working right, so it would be nice to encapsulate that for local testing.
There was a problem hiding this comment.
Yeah, there's just enough complexity in setup that having a make target would be very helpful. Thanks!
isabelizimm
left a comment
There was a problem hiding this comment.
Nice! Was able to run everything locally, the dev experience is super easy. Thanks for updating this!
This PR uses https://github.com/posit-dev/with-connect to modernize the Posit Connect test suite and get running again. See a passing CI run here: https://github.com/rstudio/pins-python/actions/runs/19110527979/job/54606158812?pr=351#step:5:192
Other changes include:
CONNECT_SERVERandCONNECT_API_KEYenv vars for those values by default, for consistency with other Connect API clients and the Connect documentation_HackyConnecttoLoginConnectApibecause all it does is allow you to log in with username and password instead of API key. But left the old_HackyConnectin there because I found at least one other of our packages using it. Will circle back to remove it once that's cleaned up.test_board_pin_search_admin_user, is skipped: for some reason this didn't work with the new setup. However, I think it is really just testing how Connect does authorization, not howpinsworks, so I'm not sure it is necessary.There's more cleanup I'd like to do here, but maybe I'll follow up with something else, just to keep this PR more focused.
Fix #341