try catch for writeStagedState serialize#1315
Open
SethArchambault wants to merge 2 commits intort2zz:masterfrom
Open
try catch for writeStagedState serialize#1315SethArchambault wants to merge 2 commits intort2zz:masterfrom
SethArchambault wants to merge 2 commits intort2zz:masterfrom
Conversation
Even though there was ".catch" on this line, it only caught errors from setItem, so an error from serialize would be completely unhandled.
…h-patch-1 try catch for writeStagedState serialize
Emad-salah
added a commit
to Emad-salah/redux-persist
that referenced
this pull request
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though there was ".catch" on this line, it only caught errors from setItem, so an error from serialize would be completely unhandled.