Conversation
There was a problem hiding this comment.
Pull request overview
Updates the dependency set used by the wp-e2e-playwright E2E test harness to newer Playwright/WordPress tooling and related packages.
Changes:
- Bump Playwright (
playwright,@playwright/test) to^1.58.2. - Bump WordPress tooling packages (e.g.,
@wordpress/scripts,@wordpress/*) to newer versions. - Refresh several supporting dependencies (
dotenv,form-data,lodash,playwright-tesults-reporter).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@wordpress/scripts": "^31.5.0", | ||
| "dotenv": "^16.6.1", | ||
| "form-data": "^4.0.5", | ||
| "lodash": "^4.17.23", | ||
| "playwright-tesults-reporter": "^1.5.0" |
There was a problem hiding this comment.
These dependency bumps (notably @wordpress/scripts and Playwright) now require a much newer Node version (e.g., lockfile shows @wordpress/scripts needs node>=18.12 and Playwright needs node>=18, plus several transitive deps require node>=20). However this package's engines.node is still set to ">=12" in package.json, which is now inaccurate and can lead to confusing install/runtime failures on older Node versions. Please update engines.node to match the minimum version required by the updated dependency set (likely >=20).
| "@wordpress/scripts": "^31.5.0", | ||
| "dotenv": "^16.6.1", | ||
| "form-data": "^4.0.5", | ||
| "lodash": "^4.17.23", | ||
| "playwright-tesults-reporter": "^1.5.0" |
There was a problem hiding this comment.
PR title says "Update playwright packages", but this change also bumps several non-Playwright dependencies (e.g., @wordpress/scripts, dotenv, form-data, lodash, playwright-tesults-reporter). Consider updating the PR title/description to reflect the broader dependency update, or limit the scope to Playwright-only if that's the intent.
No description provided.