Skip to content

Comments

Update dependencies for security and compatibility#2296

Open
the-hercules wants to merge 6 commits intodevelopfrom
fix/dependabot-issue
Open

Update dependencies for security and compatibility#2296
the-hercules wants to merge 6 commits intodevelopfrom
fix/dependabot-issue

Conversation

@the-hercules
Copy link
Contributor

Address security vulnerabilities by updating qs, axios, and fast-xml-parser. Add necessary overrides in package.json to ensure compatibility with specific versions. Update ajv to enhance functionality.

Copilot AI review requested due to automatic review settings February 20, 2026 13:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates transitive Node dependencies to address security/compatibility concerns, primarily by bumping versions in the e2e Playwright workspace and refreshing lockfiles.

Changes:

  • Add npm overrides in tests/wp-e2e-playwright/package.json for webpack-dev-server, minimatch, fast-xml-parser, and ajv.
  • Refresh tests/wp-e2e-playwright/package-lock.json to pick up axios, qs, fast-xml-parser, ajv, and related dependency tree updates.
  • Refresh root package-lock.json, including a qs update.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/wp-e2e-playwright/package.json Adds overrides to force specific dependency versions.
tests/wp-e2e-playwright/package-lock.json Lockfile refresh reflecting the new overrides and dependency upgrades.
package-lock.json Root lockfile refresh including a qs bump.
Files not reviewed (1)
  • tests/wp-e2e-playwright/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +59 to +60
"fast-xml-parser": "5.3.7",
"ajv": "8.18.0"
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding ajv to 8.18.0 forces it outside some dependents’ declared ranges (e.g. npm-package-json-lint in the lockfile depends on ajv@^6.12.6). This can lead to runtime failures due to Ajv v6→v8 breaking API changes. Consider scoping the override to packages that already require Ajv v8, or upgrading/replacing the Ajv-v6 consumers so the dependency graph stays semver-compatible.

Suggested change
"fast-xml-parser": "5.3.7",
"ajv": "8.18.0"
"fast-xml-parser": "5.3.7"

Copilot uses AI. Check for mistakes.
"overrides": {
"webpack-dev-server": "^5.2.1"
},
"webpack-dev-server": "^5.2.1",
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overrides.webpack-dev-server is a range (^5.2.1). For security/compatibility overrides, pinning an exact version makes installs reproducible and prevents pulling in a future vulnerable minor/patch unintentionally.

Suggested change
"webpack-dev-server": "^5.2.1",
"webpack-dev-server": "5.2.1",

Copilot uses AI. Check for mistakes.
"webpack-dev-server": "^5.2.1"
},
"webpack-dev-server": "^5.2.1",
"minimatch": "10.2.1",
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The override forces minimatch@10.2.1, which requires Node 20 || >=22 (per the resolved package metadata). This conflicts with this package’s declared engine (>=12) and will break installs on Node 12–19. Either bump the engines.node constraint (and any documented Node requirement) or use a minimatch version compatible with the supported Node range.

Suggested change
"minimatch": "10.2.1",
"minimatch": "5.1.6",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant